Fix bat scripts to work with JAVA_HOME containing special characters #38965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
added
:Delivery/Packaging
|
Pinging @elastic/es-core-infra |
|
ok to test |
|
This: bin\elasticsearch-plugin install file:///C:/bla/ingest-attachment-6.6.0.zip still throws an error: \Common was unexpected at this time. |
|
@csetzkorn thank you for this - will indeed increase the scope of this PR to include fixes to all windows bat scripts using to JAVA_HOME with '(' or ' ' |
|
@csetzkorn can you please confirm that you had the failure you mentioned after applying the patch from this PR? |
|
@elasticmachine run elasticsearch-ci/packaging |
pgomulka
force-pushed
the
feature/windows_startup_scripts
branch
from
e3d136f to
cc33dc3
Compare
the elasticsearch.bat and elasticsearch-env.bat won't work if JAVA contains parentheses. This seems to be the limitation of FOR /F IN (command) DO syntax. The JAVA variable present in a command contains a path to a binary to start elasticsearch (with spaces & parans). We can workaround the problem of spaces and parentheses in this path by referring this variable with a CALL command. Note that executing binaries with CALL is an undocumented behaviour (but works)
pgomulka
force-pushed
the
feature/windows_startup_scripts
branch
from
cc33dc3 to
14cd39f
Compare
|
closing as cannot resolve the conflicts after the base change (seems to be a github bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
elasticsearch.batandelasticsearch-env.batwon't work ifJAVAcontains parentheses. This seems to be the limitation ofFOR /F IN (command) DOsyntax.The
JAVAvariable present in a command contains a path to a binary to start elasticsearch (with spaces & parans). We can workaround the problem of spaces and parentheses in this path by referring this variable with aCALLcommand.Note that executing binaries with
CALLis an undocumented behaviour (but works)closes #38578
closes #38624
closes #33405
closes #30606