Introduce StepListener #37327
Merged
Introduce StepListener #37327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces StepListener which provides a simple way to write a flow consisting of multiple asynchronous steps without having nested callbacks.
dnhatn
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
jaymode
reviewed
Jan 11, 2019
server/src/main/java/org/elasticsearch/action/StepListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/StepListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/StepListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/StepListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/StepListener.java
Outdated
Show resolved
Hide resolved
|
@jaymode Thanks for looking. I have fixed the concurrency issue. Would you please have another look? Thank you!
Agreed, I'll look into this later. |
s1monw
approved these changes
Jan 11, 2019
Good idea. I will do it. |
dnhatn
added a commit
that referenced
this pull request
Jan 12, 2019
This commit introduces StepListener which provides a simple way to write a flow consisting of multiple asynchronous steps without having nested callbacks. Relates #37291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces StepListener which provides a simple way to write
a flow consisting of multiple asynchronous steps without having nested
callbacks.
Relates #37291