Skip to content

Test: Fix last reference to SearchScript #34731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2018
Merged

Test: Fix last reference to SearchScript #34731

merged 4 commits into from
Oct 24, 2018

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Oct 23, 2018

This was accidentally left over when converting to FieldScript.

closes #34683

@rjernst
Test: Fix last reference to SearchScript
60bdaf5 
This was accidentally left over when converting to FieldScript.

closes elastic#34683
@rjernst rjernst added >bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0 v6.5.0 labels Oct 23, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst rjernst mentioned this pull request Oct 23, 2018
Closed
@rjernst
Copy link
Member Author

rjernst commented Oct 23, 2018

@elasticmachine test this please

@atapin atapin mentioned this pull request Oct 23, 2018
Merged
jasontedor
jasontedor reviewed Oct 23, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the empty test testEmptyToLetBuildPass that was added too?

@rjernst
Copy link
Member Author

rjernst commented Oct 23, 2018

Weird, I swear I did that before. Done now!

jasontedor
jasontedor approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rjernst rjernst merged commit 596b5cf into elastic:master Oct 24, 2018
@rjernst rjernst deleted the fix_domain_split branch October 24, 2018 00:26
kcm pushed a commit that referenced this pull request Oct 30, 2018
@rjernst @kcm
Test: Fix last reference to SearchScript (#34731)
9b8cecf 
This was accidentally left over when converting to FieldScript.

closes #34683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
>bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v6.5.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PainlessDomainSplitIT#testIsolated fails reliably with compilation error
4 participants
@rjernst @elasticmachine @jasontedor @colings86