-
Notifications
You must be signed in to change notification settings - Fork 25.3k
HLRC: Add activate watch action #33988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8c4487d
HLRC: Add activate watcher action
iverase 8533941
remove unused imports
iverase 0a27785
Merge branch 'master' into activateWatcher
iverase 95c874a
Implemented first round of PR comments
iverase cdd2579
rename test
iverase 70dcf64
Merge remote-tracking branch 'origin/master' into activateWatcher
iverase 4a3db30
Update docs and cos test using new approach
iverase b1bd977
merge with head and resolve conflicts
iverase 04ed79a
remove extra space
iverase 78f88d0
add response test
iverase 7799655
clean up request and response classes
iverase d602424
remove unused import
iverase 17705f2
Merge branch 'master' into activateWatcher
iverase File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
.../rest-high-level/src/main/java/org/elasticsearch/client/watcher/ActivateWatchRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.elasticsearch.client.watcher; | ||
|
||
import org.elasticsearch.client.Validatable; | ||
import org.elasticsearch.protocol.xpack.watcher.PutWatchRequest; | ||
|
||
import java.util.Objects; | ||
|
||
/** | ||
* A request to explicitly activate a watch. | ||
*/ | ||
public final class ActivateWatchRequest implements Validatable { | ||
|
||
private final String watchId; | ||
|
||
public ActivateWatchRequest(String watchId) { | ||
this.watchId = Objects.requireNonNull(watchId, "Watch identifier is required"); | ||
if (PutWatchRequest.isValidId(this.watchId) == false) { | ||
throw new IllegalArgumentException("Watch identifier contains whitespace"); | ||
} | ||
} | ||
|
||
/** | ||
* @return The ID of the watch to be activated. | ||
*/ | ||
public String getWatchId() { | ||
return watchId; | ||
} | ||
|
||
@Override | ||
public boolean equals(Object o) { | ||
if (this == o) return true; | ||
if (o == null || getClass() != o.getClass()) return false; | ||
ActivateWatchRequest that = (ActivateWatchRequest) o; | ||
return Objects.equals(watchId, that.watchId); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
int result = Objects.hash(watchId); | ||
return result; | ||
} | ||
} |
71 changes: 71 additions & 0 deletions
71
...rest-high-level/src/main/java/org/elasticsearch/client/watcher/ActivateWatchResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
/* | ||
* Licensed to Elasticsearch under one or more contributor | ||
* license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright | ||
* ownership. Elasticsearch licenses this file to you under | ||
* the Apache License, Version 2.0 (the "License"); you may | ||
* not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.elasticsearch.client.watcher; | ||
|
||
import org.elasticsearch.common.ParseField; | ||
import org.elasticsearch.common.xcontent.ConstructingObjectParser; | ||
import org.elasticsearch.common.xcontent.XContentParser; | ||
|
||
import java.io.IOException; | ||
import java.util.Objects; | ||
|
||
/** | ||
* Response from an 'activate watch' request. | ||
*/ | ||
public final class ActivateWatchResponse { | ||
|
||
private static final ParseField STATUS_FIELD = new ParseField("status"); | ||
private static ConstructingObjectParser<ActivateWatchResponse, Void> PARSER = | ||
new ConstructingObjectParser<>("activate_watch_response", true, | ||
a -> new ActivateWatchResponse((WatchStatus) a[0])); | ||
|
||
static { | ||
PARSER.declareObject(ConstructingObjectParser.constructorArg(), | ||
(parser, context) -> WatchStatus.parse(parser), | ||
STATUS_FIELD); | ||
} | ||
|
||
private final WatchStatus status; | ||
|
||
public ActivateWatchResponse(WatchStatus status) { | ||
this.status = status; | ||
} | ||
|
||
public WatchStatus getStatus() { | ||
return status; | ||
} | ||
|
||
@Override | ||
public boolean equals(Object o) { | ||
if (this == o) return true; | ||
if (o == null || getClass() != o.getClass()) return false; | ||
ActivateWatchResponse that = (ActivateWatchResponse) o; | ||
return Objects.equals(status, that.status); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return Objects.hash(status); | ||
} | ||
|
||
public static ActivateWatchResponse fromXContent(XContentParser parser) throws IOException { | ||
return PARSER.parse(parser, null); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have a new ay to deal with the docs+test, we should wait to merge until it is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hub-cap which is the issue that it is introducing this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#34125 and it looks like its merged!