Zen2: Add DisruptableMockTransport #33713
Conversation
ywelsch
added
WIP
v7.0.0
:Distributed Coordination/Cluster Coordination
|
Pinging @elastic/es-distributed |
|
@elasticmachine retest this please |
| } | ||
|
|
||
|
|
||
| static class DummyRequest extends TransportRequest { |
There was a problem hiding this comment.
Why not TransportRequest.Empty?
| } | ||
|
|
||
| protected void onSendRequest(long requestId, String action, TransportRequest request, DiscoveryNode node) { | ||
| requests.put(requestId, Tuple.tuple(node, action)); |
There was a problem hiding this comment.
All the implementations call super(...) up front, and I think it'd be bad not to, so I think it'd be better to move this into sendRequest() above.
| private TransportMessageListener listener; | ||
| private ConcurrentMap<Long, Tuple<DiscoveryNode, String>> requests = new ConcurrentHashMap<>(); | ||
|
|
||
| public TransportService createTransportService(Settings settings, ThreadPool threadPool, TransportInterceptor interceptor, |
There was a problem hiding this comment.
The newly-merged CoordinatorTests also call this method with its old name.
|
|
||
| @Override | ||
| public String getChannelType() { | ||
| return "test-channel"; |
There was a problem hiding this comment.
Not sure where this string appears, but something more specific might be useful. Maybe disruptable-mock-transport-channel?
| }; | ||
|
|
||
| try { | ||
| requestHandler.processMessageReceived(request, transportChannel); |
There was a problem hiding this comment.
IntelliJ complains about lack of genericness for this call. Could it move to its own method on which such warnings are suppressed?
Adds a mock transport implementation that allows to simulate network disruptions.