INGEST: Tests for Drop Processor #33430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* UT for behavior of dropped callback and drop processor * Moved drop processor to `server` project to enable this test * Simple IT * Relates elastic#32278
original-brownbear
added
>test
|
Pinging @elastic/es-core-infra |
|
@rjernst can you take a look here? :) I think we should at least have some basic tests for this. |
jakelandis
reviewed
Sep 25, 2018
| public void testExecuteWithDrop() { | ||
| IngestService ingestService = createWithProcessors(Collections.singletonMap("drop", new DropProcessor.Factory())); | ||
| PutPipelineRequest putRequest = new PutPipelineRequest("_id", | ||
| new BytesArray("{\"processors\": [{\"drop\" : {}}]}"), XContentType.JSON); |
There was a problem hiding this comment.
minor: you may also want a second (mock) processor here, and assert that the second processor never executes.
|
LGTM, one minor optional suggestion. |
|
@jakelandis thanks! Suggestion applied :) |
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 23, 2018
* INGEST: Tests for Drop Processor * UT for behavior of dropped callback and drop processor * Moved drop processor to `server` project to enable this test * Simple IT * Relates elastic#32278
jakelandis
pushed a commit
that referenced
this pull request
Oct 23, 2018
* INGEST: Tests for Drop Processor * UT for behavior of dropped callback and drop processor * Moved drop processor to `server` project to enable this test * Simple IT * Relates #32278
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* INGEST: Tests for Drop Processor * UT for behavior of dropped callback and drop processor * Moved drop processor to `server` project to enable this test * Simple IT * Relates #32278
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and drop processor
serverproject to enable this test (otherwise I would've had to add code for a dummy processor that returnsnullin the server tests for testing the callback ... moving the proc seemed more reasonable :))