MINOR+CORE: Remove Dead Methods ClusterService #33346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* None of these methods are used anywhere
original-brownbear
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
…s-cluster-state-service
…s-cluster-state-service
jasontedor
reviewed
Sep 5, 2018
| @@ -349,13 +342,6 @@ private void submitStateUpdateTask(final String source, final ClusterStateTaskCo | |||
| } | |||
| } | |||
|
|
|||
| /** asserts that the current thread is the cluster state update thread */ | |||
| public static boolean assertClusterStateUpdateThread() { | |||
There was a problem hiding this comment.
I am looking into the history of why this method is no longer used. We definitely use to assert this from, for example, ZenDiscovery at least as recently as the 5.6 days.
There was a problem hiding this comment.
Okay, this makes sense. It happened when we separated the cluster applier service from the master service.
|
@jasontedor thanks! |
original-brownbear
deleted the
remove-dead-methods-cluster-state-service
branch
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 5, 2018
* None of these methods are used anywhere
original-brownbear
added a commit
that referenced
this pull request
Sep 5, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 5, 2018
* master: Fix deprecated setting specializations (elastic#33412) HLRC: split cluster request converters (elastic#33400) HLRC: Add ML get influencers API (elastic#33389) Add conditional token filter to elasticsearch (elastic#31958) Build: Merge xpack checkstyle config into core (elastic#33399) Disable IndexRecoveryIT.testRerouteRecovery. INGEST: Implement Drop Processor (elastic#32278) [ML] Add field stats to log structure finder (elastic#33351) Add interval response parameter to AutoDateInterval histogram (elastic#33254) MINOR+CORE: Remove Dead Methods ClusterService (elastic#33346)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a random find while researching something else :)