migrate more actions to protocol.xpack #32892
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this PR creates client-side instances of the following actions: - DeleteAction - ForceMergeAction - ReadOnlyAction - RolloverAction - ForceMergeAction ShrinkAction and AllocateAction are done separately
talevy
added
the
:Data Management/ILM+SLM
|
hey all. I've requested review. but I guess this review should be pending the review for Allocate Action since I want that one to govern how the rest of these are brought into the client |
colings86
requested changes
Aug 16, 2018
| org.elasticsearch.protocol.xpack.indexlifecycle.RolloverAction::parse), | ||
| new NamedXContentRegistry.Entry(org.elasticsearch.protocol.xpack.indexlifecycle.ShrinkAction.class, | ||
| new ParseField(org.elasticsearch.protocol.xpack.indexlifecycle.ShrinkAction.NAME), | ||
| org.elasticsearch.protocol.xpack.indexlifecycle.ShrinkAction::parse) |
There was a problem hiding this comment.
Same comment here as in the allocate action PR about needing a common categoryClass for all the actions so we can deserialise them without knowing the exact action type and also same comment about moving the registration of the server side objects away from the client.
colings86
approved these changes
Aug 16, 2018
|
|
||
| /** | ||
| * Parent class for the client-side ilm actions for the {@link NamedXContentRegistry} | ||
| */ |
There was a problem hiding this comment.
Same comment as in http://github.com/elastic/elasticsearch/pull/32853
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
this PR creates client-side instances of the following actions: - DeleteAction - ForceMergeAction - ReadOnlyAction - RolloverAction - ForceMergeAction AllocateAction was done separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR creates client-side instances of the following actions:
AllocateAction can be found here (#32853)