Skip to content

add ILM rolling upgrade tests #32828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 26, 2018
Merged

add ILM rolling upgrade tests #32828

merged 12 commits into from
Oct 26, 2018

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Aug 13, 2018 •
edited
Loading

Adds basic rolling upgrade tests to check that lifecycles are still recognizable between rolling cluster upgrades and managed indices stay managed.

This is a placeholder for discussing types of checks so they are ready once we backported

@talevy talevy added WIP :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Aug 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine elasticmachine mentioned this pull request Aug 13, 2018
Closed
@talevy talevy added the stalled label Aug 14, 2018
@dakrone
Copy link
Member

dakrone commented Oct 3, 2018

@elasticmachine test this please

@talevy
Copy link
Contributor Author

talevy commented Oct 24, 2018 •
edited
Loading

thanks for helping keep this branch up to date @dakrone.

I've updated to reflect reality after we've added the index-lifecycle-6.x branch.

CI should be up-to-date with this, so hopefully CI goes green. Things went green locally with the following gradle build argument

-Dtests.bwc.refspec.6.x=elastic/index-lifecycle-6.x

@talevy
Copy link
Contributor Author

talevy commented Oct 24, 2018

one additional thing to note: since ILM runs on the master node, I am not sure how much value there is in running these tests (at least as how they are now) on 6.x

@talevy
Copy link
Contributor Author

talevy commented Oct 24, 2018

test this please

@talevy
Copy link
Contributor Author

talevy commented Oct 25, 2018

test this please

@talevy talevy requested review from dakrone and removed request for dakrone, colings86 and gwbrown October 25, 2018 22:23
@talevy talevy requested review from colings86 and gwbrown October 25, 2018 22:23
@talevy
Copy link
Contributor Author

talevy commented Oct 26, 2018

test this please

build was done using a stale worker that had the following argument

-Dtests.bwc.refspec=elastic/index-lifecycle-6.x

should be

-Dtests.bwc.refspec.6.x=elastic/index-lifecycle-6.x

@talevy
Copy link
Contributor Author

talevy commented Oct 26, 2018

test this please

@talevy
Copy link
Contributor Author

talevy commented Oct 26, 2018

update from CI: this PR will not be run with the appropriate bwc branch, so it will not go green until after merging

dakrone
dakrone approved these changes Oct 26, 2018
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy
Copy link
Contributor Author

talevy commented Oct 26, 2018

thanks for the review @dakrone!

merging after a green run on a local run of

./gradlew :x-pack:qa:rolling-upgrade:with-system-key:check -Dtests.bwc.refspec.6.x=elastic/index-lifecycle-6.x

I have confirmed that the CI for the index-lifecycle branch is leveraging this new build argument and so it should pass upstream.

@talevy talevy merged commit 5c88356 into elastic:index-lifecycle Oct 26, 2018
@talevy talevy deleted the ilm-rolling-upgrade branch October 26, 2018 22:40
talevy added a commit that referenced this pull request Oct 30, 2018
@talevy
Revert "add ILM rolling upgrade tests (#32828)"
6cf7f12 
This reverts commit 5c88356.
talevy added a commit to talevy/elasticsearch that referenced this pull request Nov 7, 2018
@talevy
add ILM rolling upgrade tests (elastic#32828)
955c6dd
@talevy talevy mentioned this pull request Nov 7, 2018
Merged
talevy added a commit that referenced this pull request Nov 7, 2018
@talevy
[ILM] rolling upgrade tests (#35328)
4167c14 
Adds basic rolling upgrade tests to check that lifecycles are still recognizable between rolling cluster upgrades and managed indices stay managed.

This is a placeholder for discussing types of checks so they are ready once we backported

This is a re-boot of the previous PR against index-lifecycle that needed to be
reverted due to CI bwc issues. #32828
pgomulka pushed a commit to pgomulka/elasticsearch that referenced this pull request Nov 13, 2018
@talevy @pgomulka
[ILM] rolling upgrade tests (elastic#35328)
66cf5c7 
Adds basic rolling upgrade tests to check that lifecycles are still recognizable between rolling cluster upgrades and managed indices stay managed.

This is a placeholder for discussing types of checks so they are ready once we backported

This is a re-boot of the previous PR against index-lifecycle that needed to be
reverted due to CI bwc issues. elastic#32828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

@colings86 colings86 Awaiting requested review from colings86

@gwbrown gwbrown Awaiting requested review from gwbrown

Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@talevy @elasticmachine @dakrone