Remove RolloverIndexTestHelper #32559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `RolloverIndexTestHelper` class in favor of making a couple of getters publically accessible as well as custom building a response object using JSON parsing. Relates to elastic#29823
dakrone
added
the
:Data Management/ILM+SLM
|
Pinging @elastic/es-core-infra |
talevy
approved these changes
Aug 1, 2018
…-rollover-test-helper
colings86
requested changes
Aug 2, 2018
There was a problem hiding this comment.
As with the update settings PR I'm not sure about having the response parsed from a JSON string, it feels ugly to me and IMO more ugly than having the RollloverIndexTestHelper class. I'm wondering if we can't just make the Response constructor public?
Here this is especially ugly to me as the response is not trivial and could well change in the future. If it does, instead of immediately getting compile errors to add the new/remove the old information in the constructor call we would only find out about the change when running tests
…-rollover-test-helper
…-rollover-test-helper
…-rollover-test-helper
jasontedor
pushed a commit
that referenced
this pull request
Aug 17, 2018
* Remove RolloverIndexTestHelper This removes the `RolloverIndexTestHelper` class in favor of making a couple of getters publically accessible as well as custom building a response object using JSON parsing. Relates to #29823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
RolloverIndexTestHelperclass in favor of making a couple ofgetters publically accessible as well as custom building a response object using
JSON parsing.
Relates to #29823