Serialize application privileges in PutRoleRequest #31712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The serialization methods for `PutRoleRequest` did not handle the applicationPrivileges array. Fixes this and added tests
tvernum
added
>bug
review
:Security/Authorization
|
Pinging @elastic/es-security |
| out.writeStringArray(runAs); | ||
| refreshPolicy.writeTo(out); | ||
| out.writeMap(metadata); | ||
|
|
| final PutRoleRequest copy = new PutRoleRequest(); | ||
| copy.readFrom(out.bytes().streamInput()); | ||
|
|
||
| assertThat(copy.roleDescriptor(), equalTo(original.roleDescriptor())); |
There was a problem hiding this comment.
I see that RoleDescriptor.ApplicationPrivilege#equals
This looks to me as an oversight?
| request.cluster(randomSubsetOf(Arrays.asList("monitor", "manage", "all", "manage_security", "manage_ml", "monitor_watcher")) | ||
| .toArray(Strings.EMPTY_ARRAY)); | ||
|
|
||
| for (int i = randomIntBetween(1, 4); i > 0; i--) { |
There was a problem hiding this comment.
randomIntBetween(0, 4), would be more alike to a true request?
|
|
||
| final Supplier<String> stringWithInitialLowercase = () | ||
| -> randomAlphaOfLength(1).toLowerCase(Locale.ROOT) + randomAlphaOfLengthBetween(3, 12); | ||
| final ApplicationResourcePrivileges[] applicationPrivileges = new ApplicationResourcePrivileges[randomIntBetween(1, 5)]; |
There was a problem hiding this comment.
same heere, randomIntBetween(0, 5) would be more life-like
albertzaharovits
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization methods for
PutRoleRequestdid not handle theapplicationPrivileges array.
Fixes this and added tests