Skip to content

Deprecate unindexed phrases #31072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 6, 2018
Merged

Deprecate unindexed phrases #31072

merged 7 commits into from
Jun 6, 2018

Conversation

romseygeek
Copy link
Contributor

Companion issue to #31060 for the 6.x branch. Instead of throwing an exception, a deprecation warning is logged and a MatchNoDocsQuery is returned.

@romseygeek romseygeek added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types >deprecation v6.4.0 labels Jun 4, 2018
@romseygeek romseygeek self-assigned this Jun 4, 2018
@romseygeek romseygeek requested a review from jimczi June 4, 2018 13:43
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

jpountz
jpountz suggested changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move the phraseQuery factory method to StringFieldType rather than TextFieldType so that phrase queries on keyword fields keep failing the same way as before?

server/src/main/java/org/elasticsearch/index/mapper/MappedFieldType.java Outdated

public Query multiPhraseQuery(String field, TokenStream stream, int slop, boolean enablePositionIncrements) throws IOException {
throw new IllegalArgumentException("Can only use phrase queries on text fields - not on [" + name + "] which is of type [" + typeName() + "]");
public Query multiPhraseQuery(String field, TokenStream stream, int slop, boolean enablePositionIncrements,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could use a static deprecation logger instead of requiring callers to pass one?

@romseygeek
Copy link
Contributor Author

I think phrase queries on keyword fields will still fail in the same way? They'll get passed through to MatchQuery which will throw an exception because there are no positions indexed.

jpountz
jpountz approved these changes Jun 4, 2018
View reviewed changes
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the case then LGTM. Thanks @romseygeek.

@romseygeek
Copy link
Contributor Author

@elasticmachine retest this please

@jimczi
Copy link
Contributor

jimczi commented Jun 5, 2018

run gradle build tests

@romseygeek romseygeek mentioned this pull request Jun 6, 2018
Closed
@romseygeek romseygeek merged commit 43b32c3 into elastic:6.x Jun 6, 2018
@jimczi jimczi mentioned this pull request Jun 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimczi jimczi Awaiting requested review from jimczi

1 more reviewer

@jpountz jpountz jpountz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@romseygeek romseygeek

Labels
>deprecation >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @jimczi @jpountz