Skip to content

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented May 22, 2018

The new snapshot includes LUCENE-8324 which fixes missing checkpoint after a fully deletes segment is dropped on flush. This should fix failed tests in CorruptedFileIT suite.

Closes #30741
Closes #30577

@dnhatn dnhatn added >non-issue :Search/Search Search-related issues that do not fall into other categories v7.0.0 v6.4.0 labels May 22, 2018
@dnhatn dnhatn requested a review from jpountz May 22, 2018 13:03
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@romseygeek Can you confirm the changes to AnalysisFactoryTestCase.java look good to you?

@romseygeek
Copy link
Contributor

+1, I should open a ticket to look into integrating the protectedtermfilter into ES.

@dnhatn
Copy link
Member Author

dnhatn commented May 22, 2018

Thanks @jpountz and @romseygeek

@dnhatn dnhatn merged commit 1918a30 into elastic:master May 22, 2018
@dnhatn dnhatn deleted the another-lucene74 branch May 22, 2018 17:11
dnhatn added a commit that referenced this pull request May 22, 2018
* master:
  QA: Add xpack tests to rolling upgrade (#30795)
  Modify state of VerifyRepositoryResponse for bwc (#30762)
  Reduce CLI scripts to one-liners on Windows (#30772)
  Simplify number of shards setting (#30783)
  Replace Request#setHeaders with addHeader (#30588)
  [TEST] remove endless wait in RestClientTests (#30776)
  [Docs] Fix script-fields snippet execution (#30693)
  Upgrade to Lucene-7.4.0-snapshot-cc2ee23050 (#30778)
  [DOCS] Add SAML configuration information (#30548)
  [DOCS] Remove X-Pack references from SQL CLI (#30694)
  Make http pipelining support mandatory (#30695)
  [Docs] Fix typo in circuit breaker docs (#29659)
  [Feature] Adding a char_group tokenizer (#24186)
  [Docs] Fix broken cross link in documentation
  Test: wait for netty threads in a JUnit ClassRule (#30763)
  Increase the maximum number of filters that may be in the cache. (#30655)
  [Security] Include an empty json object in an json array when FLS filters out all fields (#30709)
  [TEST] Wait for CS to be fully applied in testDeleteCreateInOneBulk
  Add more yaml tests for get alias API (#29513)
  Ignore empty completion input (#30713)
  [DOCS] fixed incorrect default
  [ML] Filter undefined job groups from update calendar actions (#30757)
  Fix docs failure on language analyzers (#30722)
  [Docs] Fix inconsistencies in snapshot/restore doc (#30480)
  Enable installing plugins from snapshots.elastic.co (#30765)
  Remove fedora 26, add 28 (#30683)
  Accept Gradle build scan agreement (#30645)
  Remove logging from elasticsearch-nio jar (#30761)
  Add Delete Repository High Level REST API (#30666)
dnhatn added a commit that referenced this pull request May 29, 2018
The new snapshot includes LUCENE-8324 which fixes missing checkpoint
after a fully deletes segment is dropped on flush. This snapshot should
resolves failed tests in the CorruptedFileIT suite.

Closes #30741
Closes #30577
martijnvg added a commit that referenced this pull request May 30, 2018
* es/6.x: (21 commits)
  Rename methods in PersistentTasksService (#30837)
  [DOCS] Fix watcher file location
  Minor clean-up in InternalRange. (#30886)
  [DOCS] Remove reference to platinum Docker image (#30916)
  Use dedicated ML APIs in tests (#30941)
  [test] packaging: use shell when running commands (#30852)
  [DOCS] Adds missing TLS settings for auditing (#30822)
  QA: Preserve templates and snapshot on upgrades
  Upgrade to Lucene-7.4-snapshot-1cbadda4d3 (#30928)
  Upgrade to Lucene-7.4.0-snapshot-cc2ee23050 (#30778)
  Fix IndexTemplateMetaData parsing from xContent (#30917)
  [DOCS] Fixes 6.4 breaking change page
  [DOCS] Reset edit links (#30909)
  Moved keyword tokenizer to analysis-common module (#30642)
  added migration note about legacy stored script formats being deprecated
  Deprecate accepting malformed requests in stored script API (#28939)
  Remove log traces in AzureStorageServiceImpl and fix test
  Move list tasks under Tasks namespace (#30906)
  Improve allocation-disabling instructions (#30248)
  Remove AllocatedPersistentTask.getState() (#30858)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>non-issue :Search/Search Search-related issues that do not fall into other categories v6.4.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] CorruptedFileIT.testCorruptPrimaryNoReplica [CI] CorruptedFileIT.testCorruptFileThenSnapshotAndRestore failure
5 participants