Add deprecation warning for default shards #30587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a deprecation warning to 6.x inform users that the default number of shards is changing from 5 to 1. To avoid burdening our REST tests with what would effectively be a warning assertion on every REST test, we automatically assume that such warning headers are expected. However, we add a dedicated test to ensure that the warning header comes back when expected (and does not come back when it is not expected).
jasontedor
added
review
:Data Management/Indices APIs
|
Pinging @elastic/es-core-infra |
s1monw
approved these changes
May 14, 2018
rjernst
approved these changes
May 14, 2018
| // now, put the request settings, so they override templates | ||
| indexSettingsBuilder.put(request.settings()); | ||
| if (indexSettingsBuilder.get(SETTING_NUMBER_OF_SHARDS) == null) { | ||
| deprecationLogger.deprecated("the default number of shards will change from [5] to [1] in 7.0.0; " |
There was a problem hiding this comment.
nit: I think deprecation messages usually begin with a capital letter? Looks that way in most every other place I looked at a quick glance.
There was a problem hiding this comment.
It's a mix. I dislike them for exception and log messages. It especially grates on me to see the capitalization without a period (as we seem prone to do).
jasontedor
added a commit
that referenced
this pull request
May 15, 2018
This reverts commit 3bb200f.
dnhatn
added a commit
that referenced
this pull request
May 15, 2018
* 6.x: Revert "Silence IndexUpgradeIT test failures. (#30430)" [DOCS] Remove references to changelog and to highlights Revert "Mute ML upgrade test (#30458)" [ML] Fix BWC version for backport of #30125 [Docs] Improve section detailing translog usage (#30573) [Tests] Relax allowed delta in extended_stats aggregation (#30569) Fail if reading from closed KeyStoreWrapper (#30394) [ML] Reverse engineer Grok patterns from categorization results (#30125) Derive max composite buffers from max content len Update build file due to doc file rename SQL: Extract SQL request and response classes (#30457) Remove the changelog (#30593) Revert "Add deprecation warning for default shards (#30587)" Silence IndexUpgradeIT test failures. (#30430) Add deprecation warning for default shards (#30587) [DOCS] Adds 6.4.0 release highlight pages [DOCS] Adds release highlight pages (#30590) Docs: Document how to rebuild analyzers (#30498) [DOCS] Fixes title capitalization in security content LLRest: Add equals and hashcode tests for Request (#30584) [DOCS] Fix realm setting names (#30499) [DOCS] Fix path info for various security files (#30502) Docs: document precision limitations of geo_bounding_box (#30540) Fix non existing javadocs link in RestClientTests Auto-expand replicas only after failing nodes (#30553)
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 15, 2018
89 tasks
joubu
pushed a commit
to Koha-Community/Koha
that referenced
this pull request
Jan 4, 2021
…nfig With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See elastic/elasticsearch#30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl '<cluster>:9200/<myindex>_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
joubu
pushed a commit
to Koha-Community/Koha
that referenced
this pull request
Jan 7, 2021
…nfig With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See elastic/elasticsearch#30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl '<cluster>:9200/<myindex>_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 3dc90c6) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
joubu
pushed a commit
to Koha-Community/Koha
that referenced
this pull request
Jan 11, 2021
…nfig With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See elastic/elasticsearch#30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl '<cluster>:9200/<myindex>_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 3dc90c6) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit 31b3763) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
joubu
pushed a commit
to Koha-Community/Koha
that referenced
this pull request
Jan 21, 2021
…nfig With Elasticsearch 6 (>6.4), we have a warning on index creation : the default number of shards will change from [5] to [1] in 7.0.0 See elastic/elasticsearch#30587 I propose to add number_of_shards in index config. Also add number_of_replicas that is better explicit. In case on only one node, it must be 0. Test plan : 1) Use Elasticsearch 2) Apply patch and flush memcached 3) Rebuild indexes : misc/search_tools/rebuild_elasticsearch.pl -v -b -d 4) Check you dont have a warning about number of shards 5) Check the settings of index : curl '<cluster>:9200/<myindex>_biblios/_settings?pretty&filter_path=**.number_of_*' 6) You should see : "number_of_shards" : "5", "number_of_replicas" : "1" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> (cherry picked from commit 3dc90c6) Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> (cherry picked from commit 31b3763) Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> (cherry picked from commit ce3d0ff) Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a deprecation warning to 6.x inform users that the default number of shards is changing from 5 to 1. To avoid burdening our REST tests with what would effectively be a warning assertion on every REST test, we automatically assume that such warning headers are expected. However, we add a dedicated test to ensure that the warning header comes back when expected (and does not come back when it is not expected).
Relates #30539