Skip to content

Conversation

imotov
Copy link
Contributor

@imotov imotov commented May 8, 2018

Adds support for specifying the bounding box in the geo_bounding_box
query using a single geohash. It is already possible to use geohashes
as corners, this change adds support to using a single geohash as a
complete bounding box.

Closes #25154

Adds support for specifying the bounding box in the geo_bounding_box
query using a single geohash. It is already possible to use geohashes
as corners, this change adds support to using a single geohash as a
complete bounding box.

Closes elastic#25154
@imotov imotov added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes v7.0.0 v6.4.0 labels May 8, 2018
@imotov imotov requested review from jpountz and nknize May 8, 2018 23:50
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jpountz
Copy link
Contributor

jpountz commented May 9, 2018

My initial expectation was that we would accept a geo hash as the top left and bottom right locations, but fix the parsing to take the top-left corner of the top-left geohash cell and the bottom right corner of the bottom-right geohash cell. I hadn't considered adding an option to pass a single geohash directly, I need to think more about the pros/cons. If we go that path, we should probably still fix the parsing of geohashes as top-left / bottom-right coordinates?

@imotov
Copy link
Contributor Author

imotov commented May 9, 2018

If we go that path, we should probably still fix the parsing of geohashes as top-left / bottom-right coordinates?

I am not sure what we need to fix there. It looked to me that we support geohashes as top-left / bottom-right, but we treat them as points, no as bounding boxes in this case.

@jpountz
Copy link
Contributor

jpountz commented May 14, 2018

It looked to me that we support geohashes as top-left / bottom-right, but we treat them as points, no as bounding boxes in this case.

I was considering the case that someone uses a geohash that has a short length as a corner. In that case we should try to only consider the point from the geohash that makes most sense? Eg. the top-left corner of the geohash if the geohash is used as a top-left corner, and the bottom right corner of the geohash if the geohash is used as a bottom right corner?

@imotov
Copy link
Contributor Author

imotov commented May 17, 2018

Superseded by #30698

@imotov imotov closed this May 17, 2018
@imotov imotov deleted the issue-25154-smarter-geo-bounding-box-parsing branch May 1, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >enhancement >non-issue v6.4.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants