-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NPE in InternalGeoCentroidTests#testReduceRandom #29481
Merged
imotov
merged 1 commit into
elastic:master
from
imotov:issue-29480-fix-npe-in-test-reduce-random
Apr 12, 2018
Merged
Fix NPE in InternalGeoCentroidTests#testReduceRandom #29481
imotov
merged 1 commit into
elastic:master
from
imotov:issue-29480-fix-npe-in-test-reduce-random
Apr 12, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some rare cases all inputs might have 0 count and resulting in zero totalCount, and null in centroid causing NPE. Closes elastic#29480
imotov
added
>bug
>test
Issues or PRs that are addressing/adding tests
:Analytics/Aggregations
Aggregations
labels
Apr 11, 2018
Pinging @elastic/es-search-aggs |
cbuescher
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
imotov
added a commit
that referenced
this pull request
Apr 12, 2018
In some rare cases all inputs might have zero count and resulting in zero totalCount, and null in centroid causing NPE. Closes #29480
imotov
added a commit
that referenced
this pull request
Apr 12, 2018
In some rare cases all inputs might have zero count and resulting in zero totalCount, and null in centroid causing NPE. Closes #29480
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 12, 2018
* master: Fix NPE in InternalGeoCentroidTests#testReduceRandom (elastic#29481) Build: introduce keystoreFile for cluster config (elastic#29491) test: Index more docs, so that it is less likely the search request does not time out.
martijnvg
added a commit
that referenced
this pull request
Apr 13, 2018
* es/master: Add remote cluster client (#29495) Ensure flush happens on shard idle Adds SpanGapQueryBuilder in the query DSL (#28636) Control max size and count of warning headers (#28427) Make index APIs work without types. (#29479) Deprecate filtering on `_type`. (#29468) Fix auto-generated ID example format (#29461) Fix typo in max number of threads check docs (#29469) Add primary term to translog header (#29227) Add a helper method to get a random java.util.TimeZone (#29487) Move TimeValue into elasticsearch-core project (#29486) Fix NPE in InternalGeoCentroidTests#testReduceRandom (#29481) Build: introduce keystoreFile for cluster config (#29491) test: Index more docs, so that it is less likely the search request does not time out.
martijnvg
added a commit
that referenced
this pull request
Apr 13, 2018
* es/6.x: Enable skipping fetching latest for BWC builds (#29497) Add remote cluster client (#29495) Ensure flush happens on shard idle Adds SpanGapQueryBuilder in the query DSL (#28636) Fix auto-generated ID example format (#29461) Fix typo in max number of threads check docs (#29469) Add primary term to translog header (#29227) Add a helper method to get a random java.util.TimeZone (#29487) Move TimeValue into elasticsearch-core project (#29486) Fix NPE in InternalGeoCentroidTests#testReduceRandom (#29481) Build: introduce keystoreFile for cluster config (#29491) test: Index more docs, so that it is less likely the search request does not time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Analytics/Aggregations
Aggregations
>bug
>test
Issues or PRs that are addressing/adding tests
v6.2.4
v6.3.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some rare cases all inputs might have 0 count and resulting in
zero totalCount, and null in centroid causing NPE.
Closes #29480