Indices PUT Mapping API docs: Remove mapping type user and rephrase first sentence #28998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
bleskes
suggested changes
Mar 12, 2018
| @@ -1,24 +1,14 @@ | |||
| [[indices-put-mapping]] | |||
| == Put Mapping | |||
|
|
|||
| The PUT mapping API allows you to add a new type to an existing index, or add new | |||
| fields to an existing type: | |||
| The PUT mapping API allows you to define a mapping for a new or existing index by adding fields to your mapping type. | |||
There was a problem hiding this comment.
good catch, but a small nit - the put mapping api only works for existing indices. How about The PUT mapping API allows you to add fields to an existing index or to change search only settings of existing fields?
There was a problem hiding this comment.
Ah makes sense! Just made the change.
|
Done! |
bleskes
pushed a commit
that referenced
this pull request
Mar 13, 2018
…irst sentence (#28998) The current docs on [Indices APIs: PUT Mapping](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-put-mapping.html) suggests that a having number of different mapping types per index is still possible in elasticsearch versions > 6.0.0 although they have been [removed](https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html). The console code has already been updated accordingly but notes (2) and (3) on the console code still name the `user` mapping type. This PR updates the list with notes after the console code, as well as the first sentence of the docs to avoid confusion. Also, I have removed the second command from the console code as it no longer holds any value if the docs are solely on the `_doc` mapping.
bleskes
pushed a commit
that referenced
this pull request
Mar 13, 2018
…irst sentence (#28998) The current docs on [Indices APIs: PUT Mapping](https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-put-mapping.html) suggests that a having number of different mapping types per index is still possible in elasticsearch versions > 6.0.0 although they have been [removed](https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html). The console code has already been updated accordingly but notes (2) and (3) on the console code still name the `user` mapping type. This PR updates the list with notes after the console code, as well as the first sentence of the docs to avoid confusion. Also, I have removed the second command from the console code as it no longer holds any value if the docs are solely on the `_doc` mapping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current docs on Indices APIs: PUT Mapping suggests that a having number of different mapping types per index is still possible in elasticsearch versions > 6.0.0 although they have been removed. The console code has already been updated accordingly but notes (2) and (3) on the console code still name the
usermapping type.This PR updates the list with notes after the console code, as well as the first sentence of the docs to avoid confusion. Also, I have removed the second command from the console code as it no longer holds any value if the docs are solely on the
_docmapping.