Add REST tests for percentiles agg #26266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to elastic#26220
69 tasks
nik9000
approved these changes
Aug 17, 2017
| 50.0: 76.0 | ||
|
|
||
| --- | ||
| "Non-keyed test": |
There was a problem hiding this comment.
I'm not sure the word "test" buys anything in the test name.
There was a problem hiding this comment.
But how are we supposed to know it's a test?!
Hehe, point taken. Will amend on the next batch :)
polyfractal
added a commit
that referenced
this pull request
Aug 18, 2017
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to #26220
polyfractal
added a commit
that referenced
this pull request
Aug 18, 2017
There's a separate test for each TDigest and HDR Histo, to keep things clean. Related to #26220
fxdgear
reviewed
Oct 5, 2017
| 50.0: 51.0302734375 | ||
| - match: | ||
| aggregations.percentiles_double.values: | ||
| 5.0: 1.0 |
There was a problem hiding this comment.
I tink these values need to be quoted
"5.0": 1.0
Cause this is failing in the python client.
There was a problem hiding this comment.
That is consistent with the documentation for all versions I checked, from v5.3 though master, as well as 2.4 and 1.7. Seems like the test is wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a separate test for each of TDigest and HDR Histo to keep things clean. The two sets are essentially identical, with different values depending on the algo. And HDR Histo has an extra test for negative numbers
Related to #26220