Skip to content

Add REST tests for value_count, stats, extended_stats and cardinality aggs #26239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2017

Conversation

polyfractal
Copy link
Contributor

Some more REST tests for various metric aggs. :)

Related to #26220

@polyfractal polyfractal added review >test Issues or PRs that are addressing/adding tests labels Aug 16, 2017
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

body:
- index:
_index: test_1
_type: test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should try to move to doc as the single type name now whenever possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh good call, completely forgot about that. I'll edit the prior tests that I merged too, since they use the same setup.

@polyfractal polyfractal merged commit 67e003d into elastic:master Aug 17, 2017
polyfractal added a commit that referenced this pull request Aug 17, 2017
… aggs (#26239)

* Add REST tests for value_count, stats, extended_stats and cardinality aggs

Also updates the document type of of other agg REST tests to `doc`

Related to #26220
polyfractal added a commit that referenced this pull request Aug 17, 2017
… aggs (#26239)

* Add REST tests for value_count, stats, extended_stats and cardinality aggs

Also updates the document type of of other agg REST tests to `doc`

Related to #26220
@lcawl lcawl removed the v6.1.0 label Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests v6.0.0-beta2 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants