Skip to content

Include empty mappings in GET /{index}/_mappings requests #25118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2017

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jun 7, 2017

Previously this would output:

GET /test-1/_mappings

{ }

And after this change:

GET /test-1/_mappings

{
  "test-1": {
    "mappings": {}
  }
}

To bring parity back to the REST output after #24723.

Relates to #25090

Previously this would output:

```
GET /test-1/_mappings

{ }
```

And after this change:

```
GET /test-1/_mappings

{
  "test-1": {
    "mappings": {}
  }
}
```

To bring parity back to the REST output after elastic#24723.

Relates to elastic#25090
@dakrone dakrone added :Core/Infra/REST API REST infrastructure and utilities v6.0.0 labels Jun 7, 2017
@dakrone
Copy link
Member Author

dakrone commented Jun 7, 2017

(not marking this as breaking as this is "un-breaking" part of the 6.0 unreleased change from #24723)

@dakrone
Copy link
Member Author

dakrone commented Jun 8, 2017

@jasontedor can you take a look at this one also? It's very small and related to #25114

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the REST test.

@dakrone dakrone merged commit 050b7cd into elastic:master Jun 8, 2017
@dakrone
Copy link
Member Author

dakrone commented Jun 8, 2017

Thanks @jasontedor!

@dakrone dakrone deleted the get-mappings-include-empty branch December 13, 2017 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities v6.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants