Adjust line-length of transport related classes to coding standard #17730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have shortened the line-length of a few transport related classes. While I could have done that in #17133, the original PR was already big enough so I did this separately. |
| maxChunkSize, maxHeaderSize, maxInitialLineLength, this.maxContentLength, receivePredictorMin, receivePredictorMax, pipelining, pipeliningMaxEvents); | ||
| logger.debug("using max_chunk_size[{}], max_header_size[{}], max_initial_line_length[{}], max_content_length[{}], " + | ||
| "receive_predictor[{}->{}], pipelining[{}], pipelining_max_events[{}]", | ||
| maxChunkSize, maxHeaderSize, maxInitialLineLength, this.maxContentLength, |
There was a problem hiding this comment.
why isn't it aligned with the line above?
There was a problem hiding this comment.
I guess IDEA did this. I'll check again.
|
I found one minor oddity. Otherwise LGTM. |
|
@jpountz Thanks for the review! I'll check and merge afterwards. |
danielmitterdorfer
force-pushed
the
shorten-line-lengths
branch
from
4d7a0b9 to
3688629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.