Add limit to total number of fields in mapping #17203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,6 +84,8 @@ | |||
| public static final String DEFAULT_MAPPING = "_default_"; | |||
| public static final Setting<Long> INDEX_MAPPING_NESTED_FIELDS_LIMIT_SETTING = | |||
| Setting.longSetting("index.mapping.nested_fields.limit", 50L, 0, Property.Dynamic, Property.IndexScope); | |||
| public static final Setting<Long> INDEX_MAPPING_TOTAL_FIELDS_LIMIT_SETTING = | |||
| Setting.longSetting("index.mapping.total_fields.limit", 0, 0, Property.Dynamic, Property.IndexScope); | |||
There was a problem hiding this comment.
There seemed to be consensus about setting a default limit of 1000 in #13547. Let's do that?
|
@jpountz Sure. I will take a look this weekend. thanks. |
clintongormley
added
the
:Search Foundations/Mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13547
This is to prevent mapping explosion when dynamic keys such as UUID are used as field names. index.mapping.total_fields.limit specifies the total number of fields an index can have. An exception will be thrown when the limit is reached. The default limit is 0 which means no limit. This setting is runtime adjustable.