Expose the reason why a mapping merge is issued. #16059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be useful in order to only perform some validations in the case of a mapping update and in cases when a mapping is restored eg. after a restart, such as discussed in elastic#15989. This replaces the current `applyDefault` parameter which can be derived from the mapping merge reason: the default mapping should be applied only in case of a mapping update, if the mapping does not exist yet and if this is not the default mapping.
jpountz
added
>enhancement
:Search Foundations/Mapping
|
LGTM |
1 similar comment
|
LGTM |
jpountz
added a commit
that referenced
this pull request
Jan 19, 2016
Expose the reason why a mapping merge is issued.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful in order to only perform some validations in the case of
a mapping update and in cases when a mapping is restored eg. after a restart,
such as discussed in #15989.
This replaces the current
applyDefaultparameter which can be derived fromthe mapping merge reason: the default mapping should be applied only in case of
a mapping update, if the mapping does not exist yet and if this is not the
default mapping.