Remove query warmers and the warmer API. #15614
Conversation
jpountz
force-pushed
the
remove/warmers
branch
from
98d9b76 to
f20bc27
Compare
There was a problem hiding this comment.
Add an assertion to this file that major is less than 4.0 with a comment about this todo?
There was a problem hiding this comment.
just our of curiosity do we have a bwc index that has warmers? I think we should add one if we don't or regenerate the BWC indices with warmers?
There was a problem hiding this comment.
actually this won't help since we load old indices as dangling indices, so warmers won't be read since they are not part of the index metadata. So I guess we need a dedicated test?
|
LGTM if we're truly ok with warmers going away. I didn't see a test that making sure that an old index with warmers will just be ignored. Did I miss it? I think it might be as simple as trying to build an index using xcontent, specifying warmers, and asserting that the index was created without exception. |
|
LGTM - I left one comment about BWC testing |
jpountz
force-pushed
the
remove/warmers
branch
from
f20bc27 to
803e763
Compare
|
LGTM |
jpountz
force-pushed
the
remove/warmers
branch
from
803e763 to
d462a91
Compare
Warmers are now barely useful and will be removed in 3.0. Note that this only removes the warmer API and query-based warmers. We still have warmers internally for eg. global ordinals. Close elastic#15607
jpountz
force-pushed
the
remove/warmers
branch
from
d462a91 to
67d233c
Compare
Remove query warmers and the warmer API.
|
Note: if you are on 2.x and using warmers, the upgrade to 3.0 will be fine, warmers will be ignored during the upgrade. |
4 participants
Warmers are now barely useful and will be removed in 3.0. Note that this only
removes the warmer API and query-based warmers. We still have warmers internally
for eg. global ordinals.
Close #15607