Aggregations Refactor: Refactor Terms Aggregation #15386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
force-pushed
the
feature/aggs-refactoring
branch
from
5513a76 to
97cbdb8
Compare
Contributor
Author
There was a problem hiding this comment.
This class is actually not used anymore and should have been deleted. Will delete now
Contributor
Author
|
@jpountz thanks for the review, I added a commit to address your comments |
colings86
force-pushed
the
feature/aggs-refactoring
branch
from
97cbdb8 to
b147bf3
Compare
Contributor
|
LGTM |
colings86
force-pushed
the
feature/aggs-refactoring
branch
from
4fbfde6 to
cbcccb3
Compare
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.