Use native methods in BBQ calculations#149403
Open
thecoop wants to merge 3 commits into
Open
Conversation
thecoop
force-pushed
the
native-osq-sqr-calcs
branch
from
3cfa70c to
7b0a309
Compare
Update checks
thecoop
force-pushed
the
native-osq-sqr-calcs
branch
from
3ee266d to
3efc190
Compare
thecoop
commented
May 19, 2026
| // we require all prefixes to be a multiple 64, we want to take best advantage of vectorization | ||
| private static final int PREFIX_MULTIPLE = 64; | ||
| private static final int PREFIX_TOPK_SIZE = 4; | ||
| private static final int PREFIX_TOPK_SIZE = SQR_BULK_SIZE; |
Member
Author
There was a problem hiding this comment.
Is this a breaking change at all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use native methods when calculating various BBQ values for added go-faster stripes.
I've dropped the panama implementation for simplicity - it can be easily added back if required.