Make hot-threads dump sortable#149378
Open
DaveCTurner wants to merge 2 commits into
Open
Conversation
Today if a hot threads dump is split into more than 9 parts then naively sorting the messages (as strings) does not produce the correct output. This commit adds leading zeroes to the chunk indices to make them easier to sort correctly.
DaveCTurner
added
>non-issue
:Distributed/Distributed
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Member
Author
|
@nicktindall I know you had some kind of tooling for working with these log messages - asking you for input here mainly to check that this won't cause that tool any problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today if a hot threads dump is split into more than 9 parts then naively
sorting the messages (as strings) does not produce the correct output.
This commit adds leading zeroes to the chunk indices to make them easier
to sort correctly.