Skip to content

Refactor Histogram and Date Histogram Aggregation #14140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2015
Merged

Refactor Histogram and Date Histogram Aggregation #14140

merged 1 commit into from
Nov 16, 2015

Conversation

colings86
Copy link
Contributor

No description provided.

@colings86 colings86 assigned colings86 and jpountz and unassigned colings86 Oct 15, 2015
@clintongormley clintongormley mentioned this pull request Oct 15, 2015
Closed
jpountz
jpountz reviewed Oct 30, 2015
View reviewed changes
core/src/main/java/org/elasticsearch/common/rounding/Rounding.java Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm when do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't, this is left over from an idea I had for parsing and rendering Roundings. I have now removed this

@colings86 colings86 force-pushed the feature/aggs-refactoring branch 16 times, most recently from 78878b3 to 7e316ba Compare November 16, 2015 10:20
@colings86 colings86 merged commit ce3719f into elastic:feature/aggs-refactoring Nov 16, 2015
@jpountz
Copy link
Contributor

jpountz commented Nov 16, 2015

I'm a bit late to the party, but LGTM ;)

@colings86 colings86 deleted the enhancement/histogramAggRefactor branch November 16, 2015 14:22
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Search Refactoring labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpountz jpountz

Labels
:Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colings86 @jpountz @clintongormley @MaineC