chore(SemanticTextHighlighter): improve bwc tests #138662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mromaios
added
>test
elasticsearchmachine
added
the
Team:Search - Relevance
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
…om:mromaios/elasticsearch into adapt_vector_similarity_highlighting_tests
Mikep86
approved these changes
Dec 3, 2025
Contributor
Mikep86
left a comment
Mikep86
left a comment
There was a problem hiding this comment.
LGTM, assuming those serverless test failures are spurious
Collaborator
💔 Backport failedYou can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mromaios
added a commit
to mromaios/elasticsearch
that referenced
this pull request
Dec 8, 2025
(cherry picked from commit 58b9a59)
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent Issue: #136056
Depends on: #138644
While backporting #138140 the
InferenceFeaturename changed, and we had to add another one here: #138644In this PR we decouple the disk_bbq and knn similarity tests, so that the
bwccan be correcting tested