Skip to content

Fix assertion error when executing invalid row query with filter #135761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 2, 2025
Merged

Fix assertion error when executing invalid row query with filter #135761

merged 4 commits into from
Oct 2, 2025
+19 −4

Conversation

idegtiarenko
Copy link
Contributor

Similarly to #133704, running an invalid row query with any filter fails with assertion error:

[2025-10-01T10:38:27,073][ERROR][o.e.b.ElasticsearchUncaughtExceptionHandler] [runTask-0] fatal error in thread [elasticsearch[runTask-0][search][T#2]], exiting java.lang.AssertionError: ClusterMap in EsqlExecutionInfo must not be empty
        at org.elasticsearch.xpack.esql.action.EsqlExecutionInfo.getClusterStates(EsqlExecutionInfo.java:319)
        at org.elasticsearch.xpack.esql.action.EsqlExecutionInfo.getRunningClusterAliases(EsqlExecutionInfo.java:324)
        at org.elasticsearch.xpack.esql.session.EsqlCCSUtils.updateExecutionInfoWithClustersWithNoMatchingIndices(EsqlCCSUtils.java:218)
        at org.elasticsearch.xpack.esql.session.EsqlSession.lambda$analyzeWithRetry$21(EsqlSession.java:765)

this time from retry analysis flow.
This change fixes that.

@idegtiarenko idegtiarenko requested a review from smalyshev October 1, 2025 08:49
@idegtiarenko idegtiarenko added >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.2.0 v8.19.6 v9.1.6 labels Oct 1, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

luigidellaquila
luigidellaquila approved these changes Oct 1, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@idegtiarenko idegtiarenko merged commit 2e6d95a into elastic:main Oct 2, 2025
34 of 35 checks passed
@idegtiarenko idegtiarenko mentioned this pull request Oct 2, 2025
Merged
idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Oct 2, 2025
@idegtiarenko
Fix assertion error when executing invalid row query with filter (ela…
0079d53 
…stic#135761)
@idegtiarenko idegtiarenko mentioned this pull request Oct 2, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.19 Commit could not be cherrypicked due to conflicts
✅ 9.1
✅ 9.2

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 135761

idegtiarenko added a commit to idegtiarenko/elasticsearch that referenced this pull request Oct 2, 2025
@idegtiarenko
Fix assertion error when executing invalid row query with filter (ela…
baf2a84 
…stic#135761)
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
@idegtiarenko
Fix assertion error when executing invalid row query with filter (#13…
545048c 
…5761) (#135833)
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
@idegtiarenko
Fix assertion error when executing invalid row query with filter (#13…
1a1115a 
…5761) (#135832)
@idegtiarenko idegtiarenko mentioned this pull request Oct 2, 2025
Merged
@idegtiarenko idegtiarenko deleted the fix_invalid_row_with_filter branch October 2, 2025 11:37
elasticsearchmachine pushed a commit that referenced this pull request Oct 2, 2025
@idegtiarenko
[8.19] Fix assertion error when executing invalid row query with filt…
f2ca372 
…er (#135761) (#135842)

* Fix assertion error when executing invalid row query with filter (#135761)

(cherry picked from commit 2e6d95a)

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smalyshev smalyshev smalyshev approved these changes

@luigidellaquila luigidellaquila luigidellaquila approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.6 v9.1.6 v9.2.1 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@idegtiarenko @elasticsearchmachine @smalyshev @luigidellaquila