Refactor some ILM tests to not use deprecated methods #131417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And updates `MetadataMigrateToDataTiersRoutingService` to accept a `ProjectState` instead of a `ProjectResolver`.
nielsbauman
added
>test
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
PeteGillinElastic
approved these changes
Jul 17, 2025
| @@ -245,7 +244,7 @@ public static Tuple<ClusterState, MigratedEntities> migrateToDataTiersRouting( | |||
| attribute | |||
| ); | |||
| return Tuple.tuple( | |||
| ClusterState.builder(currentState).metadata(mb).putProjectMetadata(newProjectMetadataBuilder).build(), | |||
| ClusterState.builder(currentState.cluster()).metadata(mb).putProjectMetadata(newProjectMetadataBuilder).build(), | |||
There was a problem hiding this comment.
Your change here seems like a straight refactoring, so that's fine, but I have a wider question. This code is working at project scope, but it's also mutating state at the cluster scope (removing the ENFORCE_DEFAULT_TIER_PREFERENCE setting). That can't be safe, can it? Do we just not care because it's ILM? If so, it feels like we should use your annotation to call that out. If we plan to make it safe, is that tracked somewhere?
|
Nit: I just noticed you applied the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And updates
MetadataMigrateToDataTiersRoutingServiceto accept aProjectStateinstead of aProjectResolver.