Skip to content

Only use test-error-query in snapshot builds #131134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only use test-error-query in snapshot builds #131134

wants to merge 2 commits into from
+22 −15

Conversation

smalyshev
Copy link
Contributor

@smalyshev smalyshev commented Jul 11, 2025 •
edited
Loading

Fixes #130978

@smalyshev smalyshev requested a review from mark-vieira July 11, 2025 22:59
@smalyshev smalyshev mentioned this pull request Jul 11, 2025
Closed
@smalyshev smalyshev added :Search Foundations/Search Catch all for Search Foundations >test Issues or PRs that are addressing/adding tests labels Jul 11, 2025
@smalyshev smalyshev mentioned this pull request Jul 12, 2025
Merged
@mark-vieira
Copy link
Contributor

You'll want to add the test-release label to actually test this in release builds. We don't run those tests by default on pull requests.

@mark-vieira mark-vieira added the test-release Trigger CI checks against release build label Jul 14, 2025
@smalyshev
Copy link
Contributor Author

You'll want to add the test-release label to actually test this in release builds

Today I learned! Thanks!

@smalyshev smalyshev marked this pull request as ready for review July 14, 2025 18:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 14, 2025
@javanna
Copy link
Member

javanna commented Jul 15, 2025

Thanks for following up on this @smalyshev !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira Awaiting requested review from mark-vieira

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests test-release Trigger CI checks against release build v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] AsyncSearchSecurityIT class failing
4 participants
@smalyshev @mark-vieira @elasticsearchmachine @javanna