Remove ordinal grouping operator #131133
Merged
Remove ordinal grouping operator #131133
+29
−1,135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
remove-ordinals-grouping
branch
3 times, most recently
from
68ab79c to
585aed2
Compare
dnhatn
force-pushed
the
remove-ordinals-grouping
branch
from
585aed2 to
24878f6
Compare
|
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
dnhatn
commented
Jul 12, 2025
| @@ -130,6 +130,7 @@ default void add(int positionOffset, IntBlock groupIds) { | |||
|
|
|||
| /** | |||
| * Add the position-th row from the intermediate output of the given aggregator function to the groupId | |||
| * TODO: Remove this method as the grouping operator has been removed | |||
There was a problem hiding this comment.
I will remove this method in a follow-up.
|
I don't really see a performance hit at all in the nyc_taxis. Do you? It's only the |
Yes, that's correct. |
nik9000
approved these changes
Jul 15, 2025
ivancea
approved these changes
Jul 15, 2025
| | STATS max(@timestamp), count(*) BY message | ||
| | SORT message NULLS FIRST |
There was a problem hiding this comment.
The ordinal grouping operator emits output sorted by the keys, while the hash operator outputs keys in arrival order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ordinals grouping operator was introduced to speed up aggregation before ordinal blocks and related optimizations in block hashes were available. However, this operator has several issues:
keywordtype and requiresdoc_values.VALUESaggregation using this operator (see Avoid O(N^2) in VALUES with ordinals grouping #130576).Although the ordinals grouping operator is slightly faster than the hash operator with ordinal blocks, its complexity now outweighs the benefits. This PR proposes removing the operator. Below is the NYC_taxis benchmark.
Closes #98963