Add @UpdateForV10 to AbstractObjectParser methods #130738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `@UpdateForV10` annotation to the `AbstractObjectParser .declareInt` method and assigns it to the Core Infra team. This method needs to throw an `IllegalArgumentException` for non-integer values being passed, such as floats, doubles, and stringified floats and doubles.
joshua-adams-1
force-pushed
the
declare-int-update-v10
branch
from
2bfb7f6 to
5bacefc
Compare
joshua-adams-1
commented
Jul 8, 2025
| @@ -245,6 +246,7 @@ public void declareLongOrNull(BiConsumer<Value, Long> consumer, long nullValue, | |||
| ); | |||
| } | |||
|
|
|||
| @UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797 | |||
There was a problem hiding this comment.
Link to created issue - #130797
DaveCTurner
reviewed
Jul 8, 2025
Adds an `@UpdateForV10` annotation to the following methods in `AbstractObjectParser`: `declareInt`, `declareIntOrNull`, `declareLong`, `declareLongOrNull`, `declareIntArray` and `declareLongArray`. The required change is explained in https://github .com/elastic/issues/130797. The current parsing methods do not throw exceptions when floats or doubles are passed in place of longs or ints. The current behaviour is to truncate the float / double but this can lead to incorrect behaviour, and is also a discrepancy versus the stricter validation found when floats are passed as query parameters.
|
@DaveCTurner Good catch! Have expanded the PR accordingly |
joshua-adams-1
changed the title
elasticsearchmachine
added
the
needs:triage
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
removed
the
needs:triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
@UpdateForV10annotation to the following methods from theAbstractObjectParserclass:declareIntdeclareIntOrNulldeclareLongdeclareLongOrNulldeclareIntArraydeclareLongArrayand assigns it to the Core Infra team. The required change is explained in more detail in #130797. These current parsing methods do not throw exceptions when non-integer, or non-long, values, such as floats, doubles and stringified floats and doubles, are passed. The current behaviour is to truncate the floats / doubles into ints / longs. This is problematic for two reasons:
The proposed solution will be to throw
IllegalArgumentException's whenever non-integer and non-long values are passed.