Skip to content

ESQL: Refine assertion in Driver #130127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025

Conversation

GalLalouche
Copy link
Contributor

This PR refines an assertion that the next operator is never finished, which is actually possible if the next operator is an ExchangeSinkOperator.

@GalLalouche GalLalouche requested a review from dnhatn June 26, 2025 16:55
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Jun 26, 2025
@GalLalouche GalLalouche marked this pull request as ready for review June 26, 2025 16:55
@elasticsearchmachine elasticsearchmachine added v9.2.0 needs:triage Requires assignment of a team area label labels Jun 26, 2025
@GalLalouche GalLalouche added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL and removed needs:triage Requires assignment of a team area label labels Jun 26, 2025
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Gal!

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@GalLalouche GalLalouche added v9.1.0 auto-backport Automatically create backport pull requests when merged labels Jun 26, 2025
@GalLalouche GalLalouche enabled auto-merge (squash) June 26, 2025 17:00
@GalLalouche GalLalouche merged commit 8acf94b into elastic:main Jun 27, 2025
32 checks passed
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Jun 27, 2025
Refines an assertion that the next operator is never finished, which is actually possible if the next operator is an ExchangeSinkOperator.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged serverless-linked Added by automation, don't add manually Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v9.1.0 v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants