Simplify Version string used for upgrade tests #129769
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a5a0648)
|
@mosche do you think this is an improvement, or am I missing something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test failure https://gradle-enterprise.elastic.co/s/yfdppayec5omm made me wonder why and if we need to append
-SNAPSHOTto thetests.bwc.main.versionproperty.It seems to me this is not necessary; this change will not only "fix" the test failure (*), but also every test keeps working.
(*) the test failure is a test issue -- parsing/comparing that string is not a reliable assertion, but this is another story.