Skip to content

ES|QL: Resolve Keep plan added to FORK branches #129754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

ioanatia
Copy link
Contributor

fixes #129715

In order to align the output of FORK branches, we always add an explicit Keep plan at end of each branch.
However, we never actually resolve the KEEP plans we are adding.
KEEP can be unresolved in case it contains columns with unsupported or conflicting types.

Then we end up skipping validations in the verifier because the KEEP is unresolved:

plan.forEachDown(p -> {
// if the children are unresolved, so will this node; counting it will only add noise
if (p.childrenResolved() == false) {
return;
}

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, LGTM

Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ioanatia !

@ioanatia ioanatia marked this pull request as ready for review June 20, 2025 10:47
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 20, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine removed the Team:Search - Relevance The Search organization Search Relevance team label Jun 20, 2025
@ioanatia ioanatia merged commit 0c0bf6b into elastic:main Jun 20, 2025
27 checks passed
@ioanatia ioanatia deleted the fork_fix_projections branch June 20, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ES|QL: validation doesn't work after FORK
6 participants