-
Notifications
You must be signed in to change notification settings - Fork 25.3k
ES|QL: Make fork available in release builds #129606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hi @ioanatia, I've created a changelog YAML for you. Note that since this PR is labelled |
highlight: | ||
title: Release FORK in tech preview | ||
body: |- | ||
Fork is a foundational building block that allows multiple branches of execution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪 This is a thorough changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! LGTM
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
Show resolved
Hide resolved
( ENRICH idx2 on f1 with f2 = f3 ) | ||
( FORK ( WHERE a:"baz" ) ( EVAL x = [ 1, 2, 3 ] ) ) | ||
( COMPLETION a = b WITH c ) | ||
( SAMPLE 0.99 ) | ||
( INLINESTATS x = MIN(a), y = MAX(b) WHERE d > 1000 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add RERANK as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't want to add it before we finalize the syntax change - figured we might need to change it anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall OK.
Few questions but nothing blocking.
related: #121950
This takes FORK out of snapshot.
FORK will initially be available as a tech preview feature.
We want to make sure the grammar changes land this week, so that they are made available in Kibana too before FF.