Catch FileSystemException when opening direct IO #128834
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
ChrisHegarty
reviewed
Jun 3, 2025
| } else { | ||
| return super.openInput(name, context); | ||
| try { | ||
| Log.debug("Opening {} with direct IO", name); |
There was a problem hiding this comment.
How does this affect the DirectIOIT test ? Maybe we wanna make the test assertions conditional rather than skip? That way we can assert the fallback case, no? Maybe we move the log line to after the creation of the input. That way we can have a single log line in the output to know what it's doing.
There was a problem hiding this comment.
Currently the direct IO test is unaffected, as that doesn't run the test at all if this would have thrown. We could include the negative test - that the exception is logged if direct IO is not supported?
thecoop
force-pushed
the
handle-fs-exception
branch
from
9e1e4e2 to
f706519
Compare
thecoop
force-pushed
the
handle-fs-exception
branch
from
f706519 to
72249f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exceptions seen in #128463 is likely to also be seen in other live scenarios with filesystems that do not support direct IO. This should be handled in production ES.