Add Downsample Action to unfollow injection logic #128788
Open
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.1.0
external-contributor
nielsbauman
added
:Data Management/ILM+SLM
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
buildkite test this |
|
buildkite test this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DownsampleAction to unfollow injection logic
Problem
When using
DownsampleActionin ILM policies on follower indices in Cross-Cluster Replication (CCR) setups, the automatic unfollow step was not being injected. This could lead to issues where the follower index attempts downsampling while still following a leader index, potentially causing replication conflicts.Solution
Added
DownsampleActionto the list of actions that trigger unfollow step injection inTimeseriesLifecycleType.shouldInjectUnfollowStep(), maintaining consistency with other data-transforming actions likeRolloverAction,ShrinkAction, andSearchableSnapshotAction. Also added corresponding test cases to verify the new behavior.DownsampleActionperforms index transformation by reducing time series data resolution, which modifies index structure in ways that are incompatible with CCR following, hence requiring the unfollow step.Checklist
Fixes #128128