[ES|QL] RERANK command default inferenceId #128685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o `.rerank-v1-elasticsearch`)
afoucret
requested review from
tteofili,
carlosdelest,
ioanatia,
ChrisHegarty and
kderusso
elasticsearchmachine
added
needs:triage
svilen-mihaylov-elastic
approved these changes
May 30, 2025
kderusso
reviewed
May 30, 2025
| @@ -40,6 +40,7 @@ | |||
| public class Rerank extends InferencePlan<Rerank> implements SortAgnostic, SurrogateLogicalPlan { | |||
|
|
|||
| public static final NamedWriteableRegistry.Entry ENTRY = new NamedWriteableRegistry.Entry(LogicalPlan.class, "Rerank", Rerank::new); | |||
| public static final Object DEFAULT_INFERENCE_ID = ".rerank-v1-elasticsearch"; | |||
There was a problem hiding this comment.
Could we not use the definition from ElasticsearchInternalService here rather than redefining it?
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
mridula-s109
pushed a commit
that referenced
this pull request
Jun 2, 2025
* [ES|QL] Make inferenceId optional for the `RERANK` command (default to `.rerank-v1-elasticsearch`) * lint * Remove old test. * Fix failing test
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
* [ES|QL] Make inferenceId optional for the `RERANK` command (default to `.rerank-v1-elasticsearch`) * lint * Remove old test. * Fix failing test
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
* [ES|QL] Make inferenceId optional for the `RERANK` command (default to `.rerank-v1-elasticsearch`) * lint * Remove old test. * Fix failing test
17 tasks
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Jun 4, 2025
* [ES|QL] Make inferenceId optional for the `RERANK` command (default to `.rerank-v1-elasticsearch`) * lint * Remove old test. * Fix failing test
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
* [ES|QL] Make inferenceId optional for the `RERANK` command (default to `.rerank-v1-elasticsearch`) * lint * Remove old test. * Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When not specified, using
.rerank-v1-elasticsearchinferenceId for the RERANK command