[8.19] Add Hugging Face Rerank support (#127966) #128455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Hugging Face Rerank support * Address comments * Add transport version * Add transport version * Add to inference service and crud IT rerank tests * Refactor slightly / error message * correct 'testGetConfiguration' test case * apply suggestions * fix tests * apply suggestions * [CI] Auto commit changes from spotless * add changelog information --------- Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> (cherry picked from commit c7cf850) # Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
elasticsearchmachine
added
needs:triage
prwhelan
added
:ml
jonathan-buttner
approved these changes
May 27, 2025
| var inference = infer(inferenceEntityId, input); | ||
| assertNonEmptyInferenceResults(inference, 1, TaskType.RERANK); | ||
| // TODO: investigate score calculation inconsistency affecting this assertion. Uncomment when fixed | ||
| // assertEquals(inference, infer(inferenceEntityId, input)); |
There was a problem hiding this comment.
I looked into this, I'm not sure why the test is working on main 🤔 I'll put up a PR to make the inference results deterministic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation