-
Notifications
You must be signed in to change notification settings - Fork 25.2k
feat: Adding VoyageAI's v3.5 models #128241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- embeddings works, tested - initial rerank code What's missing: - unit and integration tests - rerank request/response mapping and verification
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
- embeddings works, tested - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank) What's missing: - unit and integration tests
Moving dimensions to ServiceSettings
feat: VoyageAI integration
Pinging @elastic/ml-core (Team:ML) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine test this please |
@fzowl the PR requires a changelog entry usually this is auto generated but not today for some reason. I wasn't able to push a commit adding the changelog to your branch, please can you apply the patch below to add the changelog. Thanks From bb8829b0e6a7d922df60f26091ee849c4343426b Mon Sep 17 00:00:00 2001
From: David Kyle <david.kyle@elastic.co>
Date: Thu, 22 May 2025 13:37:23 +0100
Subject: [PATCH] add changelog
---
docs/changelog/128241.yaml | 5 +++++
1 file changed, 5 insertions(+)
create mode 100644 docs/changelog/128241.yaml
diff --git a/docs/changelog/128241.yaml b/docs/changelog/128241.yaml
new file mode 100644
index 00000000000..a5233571e71
--- /dev/null
+++ b/docs/changelog/128241.yaml
@@ -0,0 +1,5 @@
+pr: 128241
+summary: Add VoyageAI's v3.5 models
+area: Machine Learning
+type: enhancement
+issues: []
--
2.45.2 |
@davidkyle I added the file, can you please take a look? |
@elasticmachine test this please |
Thanks for adding the change log entry @fzowl, because of that this enhancement will appear in the release notes |
💚 Backport successful
|
gradle check
?