Skip to content

feat: Adding VoyageAI's v3.5 models #128241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 36 commits into from
May 27, 2025
Merged

feat: Adding VoyageAI's v3.5 models #128241

merged 36 commits into from
May 27, 2025

Conversation

fzowl
Copy link
Contributor

@fzowl fzowl commented May 21, 2025

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

fzowl and others added 30 commits February 5, 2025 17:09
 - embeddings works, tested
 - initial rerank code

What's missing:
 - unit and integration tests
 - rerank request/response mapping and verification
 - embeddings works, tested
 - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank)

What's missing:
 - unit and integration tests
 - embeddings works, tested
 - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank)

What's missing:
 - unit and integration tests
 - embeddings works, tested
 - rerank works, tested (https://www.elastic.co/search-labs/blog/elasticsearch-cohere-rerank)

What's missing:
 - unit and integration tests
Moving dimensions to ServiceSettings
feat: VoyageAI integration
@elasticsearchmachine elasticsearchmachine added v9.1.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels May 21, 2025
@fzowl fzowl changed the title Adding VoyageAI's v3.5 models feat: Adding VoyageAI's v3.5 models May 21, 2025
@davidkyle davidkyle self-assigned this May 22, 2025
@davidkyle davidkyle added :ml Machine learning >enhancement and removed needs:triage Requires assignment of a team area label labels May 22, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label May 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle davidkyle added v8.19.0 auto-backport Automatically create backport pull requests when merged and removed Team:ML Meta label for the ML team labels May 22, 2025
@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label May 22, 2025
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle
Copy link
Member

@fzowl the PR requires a changelog entry usually this is auto generated but not today for some reason. I wasn't able to push a commit adding the changelog to your branch, please can you apply the patch below to add the changelog. Thanks

From bb8829b0e6a7d922df60f26091ee849c4343426b Mon Sep 17 00:00:00 2001
From: David Kyle <david.kyle@elastic.co>
Date: Thu, 22 May 2025 13:37:23 +0100
Subject: [PATCH] add changelog

---
 docs/changelog/128241.yaml | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 docs/changelog/128241.yaml

diff --git a/docs/changelog/128241.yaml b/docs/changelog/128241.yaml
new file mode 100644
index 00000000000..a5233571e71
--- /dev/null
+++ b/docs/changelog/128241.yaml
@@ -0,0 +1,5 @@
+pr: 128241 
+summary: Add VoyageAI's v3.5 models
+area: Machine Learning
+type: enhancement
+issues: []
-- 
2.45.2

@fzowl
Copy link
Contributor Author

fzowl commented May 26, 2025

@davidkyle I added the file, can you please take a look?

@fzowl fzowl requested a review from davidkyle May 26, 2025 16:25
@davidkyle
Copy link
Member

@elasticmachine test this please

@davidkyle davidkyle enabled auto-merge (squash) May 27, 2025 11:36
@davidkyle
Copy link
Member

Thanks for adding the change log entry @fzowl, because of that this enhancement will appear in the release notes

@davidkyle davidkyle merged commit 52bc94e into elastic:main May 27, 2025
18 of 19 checks passed
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request May 27, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

elasticsearchmachine pushed a commit that referenced this pull request May 27, 2025
Co-authored-by: fzowl <160063452+fzowl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning Team:ML Meta label for the ML team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants