lucene_snapshot: Update to new Lucene 10.3 postings format #128240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
>non-issue
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
ChrisHegarty
commented
May 21, 2025
server/src/test/java/org/elasticsearch/index/mapper/DateFieldTypeTests.java
Outdated
Show resolved
Hide resolved
ChrisHegarty
commented
May 21, 2025
server/src/test/java/org/elasticsearch/search/query/QueryPhaseTests.java
Outdated
Show resolved
Hide resolved
ChrisHegarty
commented
May 21, 2025
server/src/main/java/org/elasticsearch/index/codec/PerFieldFormatSupplier.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
May 21, 2025
...main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsFormat.java
Outdated
Show resolved
Hide resolved
javanna
reviewed
May 21, 2025
server/src/test/java/org/elasticsearch/index/mapper/DateFieldTypeTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/index/mapper/DateFieldTypeTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/query/QueryPhaseTests.java
Outdated
Show resolved
Hide resolved
| @@ -817,6 +817,13 @@ public void testNumericSortOptimization() throws Exception { | |||
|
|
|||
| Query q = LongPoint.newRangeQuery(fieldNameLong, startLongValue, startLongValue + numDocs); | |||
|
|
|||
| // 0. test assertion - the query rewritten to a match all - https://github.com/apache/lucene/pull/14609/ | |||
| // TODO: reflow total hits expectations | |||
There was a problem hiding this comment.
this refers to the other TODO below or is it something else?
server/src/main/java/org/elasticsearch/index/codec/postings/Lucene90BlockTreeTermsWriter.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/postings/CompressionAlgorithm.java
Outdated
Show resolved
Hide resolved
thecoop
reviewed
May 22, 2025
...main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsFormat.java
Outdated
Show resolved
Hide resolved
ChrisHegarty
commented
May 22, 2025
server/src/main/java/org/elasticsearch/index/codec/PerFieldFormatSupplier.java
Show resolved
Hide resolved
thecoop
approved these changes
May 22, 2025
ChrisHegarty
commented
May 22, 2025
server/src/test/java/org/elasticsearch/index/mapper/DateFieldTypeTests.java
Show resolved
Hide resolved
javanna
approved these changes
May 23, 2025
server/src/main/java/org/elasticsearch/index/codec/postings/Lucene90BlockTreeTermsWriter.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/part-1 |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
May 23, 2025
server/src/main/java/org/elasticsearch/index/codec/Elasticsearch92Lucene103Codec.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/codec/PerFieldFormatSupplier.java
Show resolved
Hide resolved
|
While the CI is not completely green, there are some failures that seem unrelated, I'm going to merge this PR so that we can sync main into the branch also, and unblock further changes. |
ChrisHegarty
added
the
lucene_10_3_dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few different things going on in this PR, all of which are required to get the
lucene_snspahotbranch building again, but the most substantial is the update to the new Lucene 10.3 postings format,Lucene103PostingsFormat.The
Lucene90BlockTreeTermsWriterclass is used in the implementation of the 10.1 postings codec in Lucene. With the new 10.3 postings format that class is no longer needed, so it has been moved to a test-only location, in order to support backward compatibility testing.In Elasticsearch we were using Lucene90BlockTreeTermsWriter (from Lucene) directly, through our copy of the Lucene 9.0 postings format, namely ES812PostingsFormat. So if you look at ES812PostingsFormat , you should that the imports should now show that we're using our own copy.
Additionally, changes are required because of the removal of deprecated methods in IOContext, as well as the override of hints for direct IO.