Fix test to use date-time strings at corresponding precision for from and to. #127899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosche
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
the
needs:risk
mosche
added
>test
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to switching to Java time, Joda's
LocalTime#toString()consistently formatted time usingHH:mm:ss.SSS.Java's
LocalTime#toString(), however, outputs the shortest possible representation and might omit seconds, milliseconds, etc. This might causefromandtoto have a different precision once stringified.When passed through the roundup parsers, from and to might be rounded up differently due to that.
This PR fixes the test to use datetime strings at a consistent precision for
fromandto.Fixes #86284