ESQL: Fix and unmute BlockHashTests.test3BytesRefs() #127830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
nik9000
approved these changes
May 7, 2025
|
I am a bit puzzled. Looks like changes generated files, but I do not see a change in corresponding |
|
@idegtiarenko I made the changes here: #127582 Those files are not related to this fix, I just used this PR to avoid creating another PR. Sorry for the confusion! |
# Conflicts: # muted-tests.yml
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
Fixes elastic#127825 Fixes elastic#127826 After merging elastic#127582, there was a subtle change that made calls to `add(..., IntVectorBlock)` to directly call `add(..., IntVector)`. This triggered a code path in the test, throwing a NPE. Also, updated some autogenerated files that were merged before my other branch, and weren't updated
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
Fixes elastic#127825 Fixes elastic#127826 After merging elastic#127582, there was a subtle change that made calls to `add(..., IntVectorBlock)` to directly call `add(..., IntVector)`. This triggered a code path in the test, throwing a NPE. Also, updated some autogenerated files that were merged before my other branch, and weren't updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127825
Fixes #127826
After merging #127582, there was a subtle change that made calls to
add(..., IntVectorBlock)to directly calladd(..., IntVector). This triggered a code path in the test, throwing a NPE.Also, updated some autogenerated files that were merged before my other branch, and weren't updated