Skip to content

ESQL: Consider inlinestats when having field_caps check for field names #127564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 22, 2025
Merged

ESQL: Consider inlinestats when having field_caps check for field names #127564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
c07d276
Make inlinestats "transparent" to EsqlSession.fieldNames
astefan Apr 29, 2025
b6b4f52
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan Apr 30, 2025
b2d6299
Update docs/changelog/127564.yaml
astefan Apr 30, 2025
7e26ed7
Update docs/changelog/127564.yaml
astefan Apr 30, 2025
bee4222
[CI] Auto commit changes from spotless
elasticsearchmachine Apr 30, 2025
32438c9
Fix import
astefan Apr 30, 2025
de0aa5c
Merge branch 'field_names_for_inlinestats_fix' of https://github.com/…
astefan Apr 30, 2025
5e998ba
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan May 5, 2025
abeb667
One more test
astefan May 5, 2025
762e05e
Update docs/changelog/127564.yaml
astefan May 5, 2025
ae8436f
Fix capability
astefan May 5, 2025
37f6d06
Merge branch 'field_names_for_inlinestats_fix' of https://github.com/…
astefan May 5, 2025
481b91e
More tests
astefan May 20, 2025
ab7dae7
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan May 20, 2025
20652af
Review
astefan May 21, 2025
56f4513
Merge branch 'main' of https://github.com/elastic/elasticsearch into …
astefan May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/changelog/127564.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
pr: 127564
summary: Consider inlinestats when having `field_caps` check for field names
area: ES|QL
type: bug
issues:
- 127236
4 changes: 2 additions & 2 deletions ...i-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.FORK_V3;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V2;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V6;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.INLINESTATS_V7;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_LOOKUP_V12;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.JOIN_PLANNING_V1;
import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.METADATA_FIELDS_REMOTE_TEST;
Expand Down Expand Up @@ -128,7 +128,7 @@ protected void shouldSkipTest(String testName) throws IOException {
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V2.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_PLANNING_V1.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V6.capabilityName()));
assumeFalse("INLINESTATS not yet supported in CCS", testCase.requiredCapabilities.contains(INLINESTATS_V7.capabilityName()));
Copy link
Contributor Author

@astefan astefan Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V7 because I am trying to work on multiple separate issues. V6 should come from #127383

assumeFalse("LOOKUP JOIN not yet supported in CCS", testCase.requiredCapabilities.contains(JOIN_LOOKUP_V12.capabilityName()));
// Unmapped fields require a coorect capability response from every cluster, which isn't currently implemented.
assumeFalse("UNMAPPED FIELDS not yet supported in CCS", testCase.requiredCapabilities.contains(UNMAPPED_FIELDS.capabilityName()));
Expand Down
Loading
Loading