[DOCS] Fix broken images #126648
Merged
[DOCS] Fix broken images #126648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
>docs
58 tasks
|
Pinging @elastic/es-docs (Team:Docs) |
|
Perhaps we could dispense from the picture and just explain what to expect in the chart? Or leave the chart out of the snippet. I lack context though, so I might as well have suggested something impractical. Ignore my comment if you think that's the case. 🙇🏻♂️ |
kilfoyle
approved these changes
Apr 11, 2025
lcawl
changed the title
Yes, I think there's definitely a better solution but since it's a small bit of content that's being re-used (and we're trying to avoid the complexity of re-use in general), I'll go ahead with the current solution of putting the same info in two places. |
💚 Backport successful
|
lcawl
added a commit
to lcawl/elasticsearch
that referenced
this pull request
Apr 12, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to elastic/docs-content#1079
Fixes broken images in the following pages:
In the case of the images that are used in snippets...since the snippets are being used in pages that belong to two different
toc.ymlfiles in two different paths, it seems like the solution is to not re-use the snippet. Thus I've put the image in both of the appropriate folders and copied the re-used text into one of the files directly. Since the second usage of the snippet involves generated files, I've left it as-is for now.Preview