Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Test] Fix QueryableReservedRolesIT testQueryDeleteOrUpdateReservedRoles (#122803) #122807

Merged

Conversation

slobodanadamovic
Copy link
Contributor

Backports the following commits to 8.x:

…les (elastic#122803)

Adds missing `assertBusy` in `testQueryDeleteOrUpdateReservedRoles`. 
We wait for security migration to finish before test execution, but this is not 
enough to guarantee that built-in roles are synchronized into the `.security` 
index. In many cases, the roles have already been synchronized before the 
query gets executed, but in rare cases the cluster is a bit slower and the 
assertion fails because the built-in roles have not been indexed yet.

Resolves elastic#120401
@slobodanadamovic slobodanadamovic added :Security/Security Security issues without another label >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Security Meta label for security team labels Feb 17, 2025
@elasticsearchmachine elasticsearchmachine merged commit 8172440 into elastic:8.x Feb 20, 2025
20 checks passed
@slobodanadamovic slobodanadamovic deleted the backport/8.x/pr-122803 branch February 20, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants