Relax some search interfaces to allow arbitrary cancellable tasks #122188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An easy change we can split out of elastic#121885 to make that shorter.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
javanna
approved these changes
Feb 10, 2025
original-brownbear
added
auto-backport
|
Thanks Luca! |
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 4, 2025
…astic#122188) An easy change we can split out of elastic#121885 to make that shorter.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An easy change we can split out of #121885 to make that shorter. With batched execution we need to be able to pass both a per-shard and a per-search kind of task in the query phase.
Plus, the broader interface might allow for other simplifications down the road so I think it's a fine change to do in isolation.